Skip to content

chore: update ts and es-lint #8405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: update ts and es-lint #8405

wants to merge 3 commits into from

Conversation

osama-rizk
Copy link
Contributor

@osama-rizk osama-rizk commented Aug 4, 2025

Description of changes:

Update es-lint and typescript to address expanding node support #8397

Verification:

Testing manually and run the following commands successfully

  • yarn test:unit
  • yarn test:e2e
  • yarn dev
  • yarn build
  • yarn postbuild
  • yarn build:release

Related GitHub issue #8397 , if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@osama-rizk osama-rizk requested a review from a team as a code owner August 4, 2025 10:07
@osama-rizk osama-rizk self-assigned this Aug 4, 2025
.eslintrc.json Outdated
@@ -2,10 +2,14 @@
"extends": [
"next/core-web-vitals",
"plugin:@typescript-eslint/recommended",
"prettier" // prettier should always come last
"prettier"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this comment? Does this rule not apply anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets deleted by mistake. I re-added the comment back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants