ci: report AmplifyCLI-PR-Testing batch status to GitHub from cloud-pr - #14965
Closed
sarayev wants to merge 1 commit into
Closed
ci: report AmplifyCLI-PR-Testing batch status to GitHub from cloud-pr#14965sarayev wants to merge 1 commit into
sarayev wants to merge 1 commit into
Conversation
cloud-pr.sh started the PR-Testing batch without --report-build-batch-status-override, so the required GitHub commit-status "AWS CodeBuild BuildBatch us-east-1 (AmplifyCLI-PR-Testing)" was never posted to the PR head commit. As a result the required check stayed stuck on "Expected" and blocked merges even when the manual batch actually succeeded. Adding --report-build-batch-status-override to the start-build-batch invocation makes CodeBuild post the commit status back to the PR head SHA when the batch completes, so the required check resolves correctly. The project source already has reportBuildStatus enabled, so only the override flag is needed. --- Prompt: Make cloud-pr report the AmplifyCLI-PR-Testing batch status back to the GitHub PR so the required check no longer stays stuck on Expected.
Contributor
Author
|
Closing — the --report-build-batch-status-override change does not reliably make CodeBuild post the required commit-status for these runs. Not pursuing this approach; the status will be handled separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
scripts/cloud-pr.shstarts theAmplifyCLI-PR-TestingCodeBuild batch manually viaaws codebuild start-build-batch, but did not pass--report-build-batch-status-override. Because this project has no GitHub webhook, CodeBuild never posted the required commit-statusAWS CodeBuild BuildBatch us-east-1 (AmplifyCLI-PR-Testing)back to the PR head SHA. The required check therefore stayed stuck on "Expected", blocking merges even when the manual batch actually succeeded.This adds
--report-build-batch-status-overrideto thestart-build-batchinvocation so CodeBuild posts the commit status back to the PR head commit when the batch completes, allowing the required check to resolve. The CodeBuild project source already hasreportBuildStatusenabled, so only the override flag is required.Issue #, if available
N/A
Description of how you validated changes
bash -n scripts/cloud-pr.shpasses (script parses).Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.