feat(docs): unify response schema for the GetSessions endpoint#57
Closed
kaua-alves-queiros wants to merge 8 commits intoavoylenko:mainfrom
kaua-alves-queiros:main
Closed
feat(docs): unify response schema for the GetSessions endpoint#57kaua-alves-queiros wants to merge 8 commits intoavoylenko:mainfrom kaua-alves-queiros:main
kaua-alves-queiros wants to merge 8 commits intoavoylenko:mainfrom
kaua-alves-queiros:main
Conversation
…the result property
- Adopted a single predictable schema (GetSessionsResponse) for all endpoint responses - Overrides the middleware's default documentation (403), ensuring consistent return types - Added 404 response for when no sessions are found - Added a success message in the response object - Updates swagger documentation for 200, 404, 403, and 500 using the same schema - Improves SDK consistency (nswag now generates only one response class)
Owner
|
Thank you for your contribution. The PR adds a breaking change to the endpoint and I want always be compatible with older integrations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(docs): unify response schema for the GetSessions endpoint
autogenerated GetSessionsResponse in c# example