Skip to content

incompatible peer dependency #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amopitt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

incompatible peer dependency #29

amopitt wants to merge 1 commit into from

Conversation

@amopitt
Copy link

@amopitt amopitt commented Nov 13, 2022

running into peer dependency conflicts because the version is pinned to only allow to 1.6.1 < 2.0.0 however the devDependencies show its using 2.3.1

avishain
avishain reviewed Nov 14, 2022
View reviewed changes
Copy link
Owner

@avishain avishain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check it with those versions? it's working as expected?

@amopitt
Copy link
Author

amopitt commented Nov 14, 2022

Installed both peer dependencies locally within the fork, then ran npm install. Ran npm pack and installed the .tgz into our RN project. Launched via expo and it is working as I expected. I did bump the version to test locally to 2.0.0, so up to you if you accept how you want to apply a new version. Also ran the tsc task to ensure that was building properly.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avishain avishain avishain left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amopitt @avishain