Skip to content

e2e tests for new native and erc20 SAVMS #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: EmreTestContract
Choose a base branch
from

Conversation

EmreDincoglu
Copy link
Collaborator

added e2e tests for native and erc20 savms, both run without error

Why this should be merged

Adds e2e tests for the recently created ERC20 and Native token SAVMS

How this works

Uses the already in place validator testing flows

How this was tested

It is the test, ran the tests and they both worked

How is this documented

comments mostly

added e2e tests for native and erc20 savms, both run without error
@@ -29,5 +29,5 @@
PChainOwner memory disableOwner
) external;

function erc20() external view returns (IERC20Mintable);
function ERC20() external view returns (IERC20Mintable);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Function IERC20TokenSlotAuctionManager.ERC20() is not in mixedCase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant