e2e tests for new native and erc20 SAVMS #812
Open
+421
−1,578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added e2e tests for native and erc20 savms, both run without error
EmreDincoglu
requested review from
iansuvak,
geoff-vball,
bernard-avalabs,
michaelkaplan13,
mdelle1 and
ylg-avalabs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -29,5 +29,5 @@ | |||
| PChainOwner memory disableOwner | |||
| ) external; | |||
|
|
|||
| function erc20() external view returns (IERC20Mintable); | |||
| function ERC20() external view returns (IERC20Mintable); | |||
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added e2e tests for native and erc20 savms, both run without error
Why this should be merged
Adds e2e tests for the recently created ERC20 and Native token SAVMS
How this works
Uses the already in place validator testing flows
How this was tested
It is the test, ran the tests and they both worked
How is this documented
comments mostly