Skip to content

Reuse network for e2e test #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 5, 2025
Merged

Reuse network for e2e test #809

merged 8 commits into from
Aug 5, 2025

Conversation

ylg-avalabs
Copy link
Contributor

@ylg-avalabs ylg-avalabs commented Jul 10, 2025

Why this should be merged

  • Reuse network for e2e tests. It saves time to setup e2e tests.

How this works

  • The network info is persisted in a directory. When running the e2e tests, we load the network from the directory and reuse the network.
  • To reuse the network:
./scripts/e2e_test.sh --components teleporter --network-dir <network directory>

If the directory does not exist or is empty, it will be used as the root network directory for a new network.
If the directory exists and is non-empty, the network will be reused.

How this was tested

  • e2e tests

How is this documented

Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I commented on the icm-services PR, I think it would make the most sense if you specify a network_dir that doesn't exist, we should spin up a new network and save it to that directory instead of failing. That way you can specify where you want to save the network, and you can keep the same invocation on the command line between your first and subsequent runs.

@ylg-avalabs ylg-avalabs requested a review from geoff-vball July 31, 2025 19:26
@ylg-avalabs ylg-avalabs merged commit a288783 into main Aug 5, 2025
18 checks passed
@ylg-avalabs ylg-avalabs deleted the network-reuse branch August 5, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants