V1 conversion e2e test #736
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
mdelle1
geoff-vball
reviewed
Mar 12, 2025
Comment on lines
+517
to
+519
| for i := range nodes { | ||
| validationIDs = append(validationIDs, l1Info.SubnetID.Append(uint32(i))) | ||
| } |
There was a problem hiding this comment.
What's happening here?
There was a problem hiding this comment.
We're computing the initial validationIDs as the hash of the concatenated subnetID and validator index, per ACP-77
…s into test-v1-conversion
geoff-vball
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
E2E test for the migration feature added in #734
How this works
How this was tested
New E2E test that upgrades from V1 PoAValidatorManager to V2 ValidatorManager
How is this documented