[Not to be merged] Integrate Simplex within Avalanchego #3957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yacov Manevich <[email protected]>
yacovm
changed the title
maru-ava
reviewed
May 13, 2025
| @@ -24,7 +24,7 @@ const ( | |||
| DefaultNetworkTimeout = 2 * time.Minute | |||
|
|
|||
| // Minimum required to ensure connectivity-based health checks will pass | |||
| DefaultNodeCount = 2 | |||
| DefaultNodeCount = 4 | |||
There was a problem hiding this comment.
(No action required) Note that this can also be configured with the --node-count flag.
maru-ava
reviewed
May 13, 2025
| @@ -57,7 +57,7 @@ func DefaultTmpnetFlags() FlagsMap { | |||
| config.PublicIPKey: "127.0.0.1", | |||
| config.HTTPHostKey: "127.0.0.1", | |||
| config.StakingHostKey: "127.0.0.1", | |||
| config.LogDisplayLevelKey: logging.Off.String(), // Display logging not needed since nodes run headless | |||
| config.LogDisplayLevelKey: logging.Info.String(), // Display logging not needed since nodes run headless | |||
There was a problem hiding this comment.
(No action required) Note that master no longer sets a value for log display level, so the value ends up the same as log-level.
samliok
commented
May 22, 2025
Comment on lines
+1489
to
+1500
| if m.TracingEnabled { | ||
| messageSender = sender.Trace(messageSender, m.Tracer) | ||
| } | ||
|
|
||
| chainConfig, err := m.getChainConfig(ctx.ChainID) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error while fetching chain config: %w", err) | ||
| } | ||
|
|
||
| if m.TracingEnabled { | ||
| vm = tracedvm.NewBlockVM(vm, primaryAlias, m.Tracer) | ||
| } |
There was a problem hiding this comment.
@yacovm what is the purpose of setting the vm twice if tracing is enabled?
vm = tracedvm.NewBlockVM(vm, primaryAlias, m.Tracer)
There was a problem hiding this comment.
it just wraps the VM with a tracing VM
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
Need to be documented in RELEASES.md?