[tmpnet] Enable installation of chaos mesh to local kind cluster #3674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
force-pushed
the
reuse-kube-install
branch
from
f0c42ab to
b75f632
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
maru-ava
force-pushed
the
install-chaos-mesh
branch
from
edff22a to
402ad07
Compare
maru-ava
changed the title
tmpnetctl start-kind-cluster --install-chaos-mesh
maru-ava
changed the title
tmpnetctl start-kind-cluster --install-chaos-mesh
maru-ava
force-pushed
the
install-chaos-mesh
branch
from
402ad07 to
4610eb8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds an optional flag to install Chaos Mesh into a local kind cluster, updates existing ingress controller port usage to a shared constant, and integrates Chaos Mesh deployment logic with Helm and readiness checks.
- Introduces
--install-chaos-meshflag andinstallChaosMeshparameter - Adds Chaos Mesh constants,
deployChaosMesh,isChaosMeshRunning, andwaitForChaosMeshfunctions - Refactors ingress port settings to use
ingressNodePortconstant and updates the kind script comment
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/fixture/tmpnet/tmpnetctl/main.go | Adds installChaosMesh flag and passes it through to StartKindCluster |
| tests/fixture/tmpnet/start_kind_cluster.go | Defines Chaos Mesh constants, handles installChaosMesh branch, and implements Helm deployment and readiness polling |
| scripts/kind-with-registry.sh | Updates comment to reference the ingressNodePort constant |
Comments suppressed due to low confidence (2)
tests/fixture/tmpnet/start_kind_cluster.go:131
- No existing tests cover the
installChaosMeshbranch; consider adding a unit or integration test to verify that Chaos Mesh is deployed when the flag is set.
if installChaosMesh {
tests/fixture/tmpnet/start_kind_cluster.go:58
- Accessing the dashboard at
chaos-mesh.localhostrequires a hosts entry (e.g.,/etc/hosts); please document this requirement in the README or RELEASES.md.
chaosMeshDashboardHost = "chaos-mesh.localhost"
e78a019 to
0b90032
Compare
maru-ava
force-pushed
the
tmpnet-nginx-ingress
branch
from
e2231cd to
7991525
Compare
maru-ava
force-pushed
the
install-chaos-mesh
branch
from
0b90032 to
f565e8f
Compare
maru-ava
force-pushed
the
tmpnet-nginx-ingress
branch
from
7991525 to
b9f3df7
Compare
Previously the scheduling label and value required to enable exclusive scheduling were defined as flag defaults. To enable the cluster to define these defaults, the defaults are now sourced from a configmap in the target namespace.
Previously, access from outside of a kube cluster was enabled by port-forwarding through the kube API. This approach turned out incompatible with load testing because it greatly limited the rate at which transactions could be sent. The port-forwarding is replaced with nginx+ingress to ensure minimum overhead when running outside of a kube cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Deploying chaos mesh to a local kube cluster simplifies learning about the reactions of an avalanchego network to fault injection scenarios.
How this works
How this was tested
tmpnetctl start-kind-cluster --install-chaos-meshand ran a chaos experimentNeed to be documented in RELEASES.md?
N/A
TODO