Skip to content

nvdimm: update expected hot_plug_error to match new QEMU message #6535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

nvdimm: update expected hot_plug_error to match new QEMU message #6535

merged 1 commit into from
Sep 19, 2025

Conversation

BulaYoungR
Copy link

QEMU now reports "nvdimm is not enabled: add 'nvdimm=on' to '-M'" instead of the old "missing 'nvdimm' in '-M'". Updated the expected hot_plug_error in cfg (with_slot → hot_plug_nvdimm.with_node) so the test properly recognizes the failure again.
Committer: Bolatbek Issakh [email protected]

@BulaYoungR
Copy link
Author

Before fix

JOB ID     : 19a0aeda42ce370c921bb305c4f705a12e1d726b
JOB LOG    : /var/log/avocado/job-results/job-2025-09-04T05.50-19a0aed/job.log
 (1/1) type_specific.io-github-autotest-libvirt.memory.devices.nvdimm.memory_allocation_and_numa.hot_plug_nvdimm.with_node.no_numa.with_slot: STARTED
 (1/1) type_specific.io-github-autotest-libvirt.memory.devices.nvdimm.memory_allocation_and_numa.hot_plug_nvdimm.with_node.no_numa.with_slot: FAIL: Expect should fail with one of ["nvdimm is not enabled: missing 'nvdimm' in '-M'"], but failed with:\n\n\nerror: Failed to attach device from /var/tmp/xml_utils_temp__y3trmae.xml\nerror: internal error: unable to execute QEMU command 'device_add': nvdimm is n... (8.33 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/log/avocado/job-results/job-2025-09-04T05.50-19a0aed/results.html
JOB TIME   : 9.98 s

Test summary:
1-type_specific.io-github-autotest-libvirt.memory.devices.nvdimm.memory_allocation_and_numa.hot_plug_nvdimm.with_node.no_numa.with_slot: FAIL

After fix

JOB ID     : d0dcc98c6f6f7953e5e04ac76838a8d8ba237a00
JOB LOG    : /var/log/avocado/job-results/job-2025-09-04T06.34-d0dcc98/job.log
 (1/1) type_specific.io-github-autotest-libvirt.memory.devices.nvdimm.memory_allocation_and_numa.hot_plug_nvdimm.with_node.no_numa.with_slot: STARTED
 (1/1) type_specific.io-github-autotest-libvirt.memory.devices.nvdimm.memory_allocation_and_numa.hot_plug_nvdimm.with_node.no_numa.with_slot: PASS (7.40 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/log/avocado/job-results/job-2025-09-04T06.34-d0dcc98/results.html
JOB TIME   : 9.17 s

dzhengfy
dzhengfy reviewed Sep 16, 2025
View reviewed changes
libvirt/tests/cfg/memory/memory_devices/nvdimm_memory_with_memory_allocation_and_numa.cfg Outdated
hot_plug_error = "target NUMA node needs to be specified for memory device"
hot_plug_nvdimm..with_node:
hot_plug_error = "nvdimm is not enabled: missing 'nvdimm' in '-M'"
hot_plug_error = "nvdimm is not enabled: add 'nvdimm=on' to '-M'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align with the old line for indentation. And for detecting error message, we do not need to search exactly. Use below is ok.
hot_plug_error = "nvdimm is not enabled:"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BulaYoungR Please align with the old line for indentation.

dzhengfy
dzhengfy reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align with the old line for indentation.

nvdimm: update expected hot_plug_error to match new QEMU message
c71a77b 
QEMU now reports "nvdimm is not enabled: add 'nvdimm=on' to '-M'"
instead of the old "missing 'nvdimm' in '-M'". Updated the expected
hot_plug_error in cfg (with_slot → hot_plug_nvdimm.with_node) so the
test properly recognizes the failure again.
Committer: Bolatbek Issakh <[email protected]>
dzhengfy
dzhengfy approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhengfy dzhengfy merged commit db929ce into autotest:master Sep 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhengfy dzhengfy dzhengfy approved these changes

Assignees
No one assigned
Labels
minorfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BulaYoungR @dzhengfy