Add --slack=false and --alert-limit=N options, and integration tests in CI #50

teor2345 · 2025-09-26T15:11:15Z

This PR adds --slack=false and --alert-limit=N command line options. This allows us to run integration tests in CI.

It also:

randomises the choice of labs or foundation RPC servers, in unit tests and integration tests
handles full alert channel errors by restarting or exiting, rather than ignoring them
delays the startup alert until context blocks have been loaded, to confirm that actually works

Close #41

teor2345 · 2025-09-29T09:58:55Z

This is mainly testing, so I'm just going to merge it.

teor2345 added 5 commits September 26, 2025 15:45

Handle channel errors rather than ignoring them, add lint

eedf1b4

Allow --slack=false to disable Slack posting entirely

c786fe0

Delay startup alert until blocks have been loaded

cd2d6d8

Add an --alert-limit option for testing

da7d957

Randomly choose between foundation and labs nodes in unit tests

d69c842

teor2345 self-assigned this Sep 26, 2025

teor2345 added the enhancement New feature or request label Sep 26, 2025

teor2345 force-pushed the better-error-handling branch from f8c6e63 to 449fd4c Compare September 26, 2025 15:27

Add an integration test in CI that stops after the first alert

deedfbb

teor2345 force-pushed the better-error-handling branch from 449fd4c to deedfbb Compare September 26, 2025 15:39

teor2345 added this pull request to the merge queue Sep 29, 2025

teor2345 added the test Testing label Sep 29, 2025

Merged via the queue into main with commit a3abfc7 Sep 29, 2025
24 checks passed

teor2345 deleted the better-error-handling branch September 29, 2025 10:07

Provide feedback