Alert whenever an important account does anything, and de-duplicate some alerts #49
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } else { | ||
| who.into_iter().next().map(Account::Signer) | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Event Handling Fails on Multiple Initiators
The EventInfo::initiator_account method uses unreachable!() if an event contains multiple 'who' accounts. This assumes a strict event structure that external blockchain data may not always uphold, potentially causing the alerter to panic and crash. This approach also goes against the codebase's pattern of gracefully handling unexpected blockchain data.
There was a problem hiding this comment.
This is technically true, if the event is being deserialized from an array of tuples. But events are almost always structs, so duplicate names are unlikely to happen in practice:
https://docs.rs/scale-value/0.18.0/scale_value/enum.Composite.html
But just in case I'll fix this over the next few days.
Not a blocker for merging.
teor2345
force-pushed
the
sudo-actions
branch
from
695ca30 to
d5825f5
Compare
|
Updated with the "multiple |
This PR adds alerts whenever an important account signs an extrinsic or initiates an event.
It also de-duplicates alerts, using this priority order:
Other alert kinds don't need de-duplication.
This de-duplication covers most of ticket #18, but we still need to combine alerts between an extrinsic and its events. (Currently, extrinsics and events don't participate in alert de-duplication, because the logic is more complicated than a priority order.)
How to review
Commit ca21716 is pure code movement, and should be reviewed separately.