feat: add prometheus metrics for DispatchQueryPlan#3109
Merged
Conversation
github-actions
Bot
added
area/tooling
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3109 +/- ##
==========================================
+ Coverage 75.60% 75.66% +0.06%
==========================================
Files 504 505 +1
Lines 62045 62094 +49
==========================================
+ Hits 46903 46976 +73
+ Misses 11724 11700 -24
Partials 3418 3418 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 0310927 | Previous: b15effc | Ratio |
|---|---|---|---|
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) |
35398991 ns/op 175069 B/op 20202 allocs/op |
7868627 ns/op 172730 B/op 20195 allocs/op |
4.50 |
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
35398991 ns/op |
7868627 ns/op |
4.50 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) |
33867726 ns/op 172522 B/op 20195 allocs/op |
7716523 ns/op 172636 B/op 20195 allocs/op |
4.39 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
33867726 ns/op |
7716523 ns/op |
4.39 |
This comment was automatically generated by workflow using github-action-benchmark.
barakmich
force-pushed
the
barakmich/dispatch_metrics
branch
from
bf0f210 to
0310927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We weren't keeping track of Prometheus dispatch metrics for DispatchQueryPlan in our load testing. This adds them, and separable by operation.