Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions src/dsl.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,85 @@ definition user {}
expect(rightExpr.relationName).toEqual("d");
});

it("parses definition with a self permission", () => {
const schema = `definition foo {
relation viewer: bar
permission view = viewer + self
}`;
const parsed = parseSchema(schema);

expect(parsed?.definitions.length).toEqual(1);

const definition = parsed?.definitions[0];
assert(definition);
assert(definition.kind === "objectDef");
expect(definition.permissions).toHaveLength(1);

const permission = definition.permissions[0];
assert(permission);
expect(permission.name).toEqual("view");

const binExpr = permission.expr;
assert(binExpr.kind === "binary");
expect(binExpr.operator).toEqual("union");

const leftExpr = binExpr.left;
assert(leftExpr.kind === "relationref");
expect(leftExpr.relationName).toEqual("viewer");

const rightExpr = binExpr.right;
assert(rightExpr.kind === "self");
});

it("parses definition with a standalone self permission", () => {
const schema = `definition foo {
permission view = self
}`;
const parsed = parseSchema(schema);

expect(parsed?.definitions.length).toEqual(1);

const definition = parsed?.definitions[0];
assert(definition);
assert(definition.kind === "objectDef");
expect(definition.permissions).toHaveLength(1);

const permission = definition.permissions[0];
assert(permission);
expect(permission.name).toEqual("view");

const selfExpr = permission.expr;
assert(selfExpr.kind === "self");
});

it("parses definition with self in a complex expression", () => {
const schema = `definition foo {
permission first = ((a - b) + self) & d;
}`;
const parsed = parseSchema(schema);

expect(parsed?.definitions.length).toEqual(1);

const definition = parsed?.definitions[0];
assert(definition);
assert(definition.kind === "objectDef");
expect(definition.permissions).toHaveLength(1);

const permission = definition.permissions[0];
assert(permission);

const binExpr = permission.expr;
assert(binExpr.kind === "binary");
expect(binExpr.operator).toEqual("intersection");

const leftExpr = binExpr.left;
assert(leftExpr.kind === "binary");
expect(leftExpr.operator).toEqual("union");

const rightLeftExpr = leftExpr.right;
assert(rightLeftExpr.kind === "self");
});

it("parses definition with multiple permissions", () => {
const schema = `definition foo {
permission first = firstrel
Expand Down
28 changes: 27 additions & 1 deletion src/dsl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ export function flatMapExpression<T>(
return nilResult ? [nilResult] : [];
}

case "self": {
const selfResult = walker(expr);
return selfResult ? [selfResult] : [];
}

case "relationref": {
const result = walker(expr);
return result ? [result] : [];
Expand Down Expand Up @@ -280,7 +285,8 @@ export type ParsedExpression =
| ParsedRelationRefExpression
| ParsedArrowExpression
| ParsedNamedArrowExpression
| ParsedNilExpression;
| ParsedNilExpression
| ParsedSelfExpression;

export type ParsedArrowExpression = {
kind: "arrow";
Expand Down Expand Up @@ -309,6 +315,11 @@ export type ParsedNilExpression = {
range: TextRange;
};

export type ParsedSelfExpression = {
kind: "self";
range: TextRange;
};

export type ParsedBinaryExpression = {
kind: "binary";
operator: "union" | "intersection" | "exclusion";
Expand Down Expand Up @@ -582,13 +593,28 @@ const nilExpr: Parser<ParsedNilExpression> = lazy(() => {
);
});

const selfExpr: Parser<ParsedSelfExpression> = lazy(() => {
return seqMap(
index,
string("self"),
index,
function (startIndex, _data, endIndex) {
return {
kind: "self",
range: { startIndex: startIndex, endIndex: endIndex },
};
},
);
});

const parensExpr = lazy(() =>
string("(")
.then(expr)
.skip(string(")"))
.or(arrowExpr)
.or(namedArrowExpr)
.or(nilExpr)
.or(selfExpr)
.or(relationReference),
);

Expand Down
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export type {
ParsedBinaryExpression,
ParsedExpression,
ParsedRelationRefExpression,
ParsedSelfExpression,
TypeRef,
} from "./dsl";
export { ResolvedDefinition, Resolver } from "./resolution";
Expand Down
Loading