Skip to content

Comments

doc(readme): add auth.error check to auto sign in#1090

Open
jnschbrt wants to merge 1 commit intoauthts:mainfrom
jnschbrt:main
Open

doc(readme): add auth.error check to auto sign in#1090
jnschbrt wants to merge 1 commit intoauthts:mainfrom
jnschbrt:main

Conversation

@jnschbrt
Copy link

  • add auth.error to auto login to prevent infinite loop when request fails

I had this problem when I got a CORS error. Therefore an endless loop was triggered during auto login

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@pamapa
Copy link
Member

pamapa commented Jan 16, 2024

Thanks for reporting back and improving the docs.

I thought hasTriedSignin would take care of endless loops, maybe we just need to flip the sequence?

  auth.signinRedirect();
  setHasTriedSignin(true);

->
  setHasTriedSignin(true);
  auth.signinRedirect();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants