Add support for checkpoint based pagination when fetching a list of clients#746
Open
PhillipTr01 wants to merge 1 commit intoauth0:masterfrom
Open
Conversation
Contributor
|
Hi @PhillipTr01 You’re right, currently the SDK doesn’t support checkpoint pagination properly because the next value isn’t set automatically when using q, from, and take. Overriding the constructor and extending to set those parameters manually works. That said, there’s a minor refactoring in progress that will affect this endpoint. Once that lands, I’ll update the SDK to reflect the changes (including those related to this endpoint). I’ll keep you posted as things move forward. Thanks again for raising the PR !! |
Author
|
Hey @tanya732, are there any updates on this pull request :)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Based on the documentation it is possible to use the Query Parameters
q,takeandfromfor checkpoint based pagination. The problem was that the library doesn't support this yet. Thenextvalue won't be set. Overriding the existing constructor with one that sets thenextparameter fixes this.Testing
There is currently no test suite for checking if pagination is working. Manual Testing is possible by creating a ExtendedClientFilter (in my case i tested it with Kotlin) in your application:
Calling the
.clients().list()function returns thenextvariable in the body.Checklist