fix(okhttp-bom): use platform keyword to implement okhttp-bom#118
Open
Bazni wants to merge 1 commit intoauth0:masterfrom
Open
fix(okhttp-bom): use platform keyword to implement okhttp-bom#118Bazni wants to merge 1 commit intoauth0:masterfrom
Bazni wants to merge 1 commit intoauth0:masterfrom
Conversation
rontho
approved these changes
Dec 20, 2024
|
@ionutmanolache-okta any chance this fix can get merged and release please ? Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
There is an error when importing this package on newer android version. As said in this issue the
okhttp-bomwasn't imported correctly.I used the keyword
platformto importokhttp-bom.References
You will find my issue here.
I also think this issue will be fixed by my fix.
Testing
I tried it on my app, now it compile and work.
Checklist