Refactor common things out of Makefiles #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ease adding new boards to projects, abstract out all the common bits into separate files. Do the same for the toolchain bits. Signed-off-by: Peter Chubb <[email protected]>
common: MUSL isn't defined yet so this fixes the issue of including /lib fileio.mk: not using eth driver firewall: imx8mp_iotgate defines ETH_DRIV_DIR not ETH_DRIV_DIR0 Signed-off-by: dumsum <[email protected]>
dumsum
reviewed
Sep 18, 2025
| -MD \ | ||
| -MP \ | ||
| -Wall \ | ||
| -Wno-unused-function \ |
There was a problem hiding this comment.
Should we keep these warnings off or perhaps add them to toolchain snippet?
-Wno-unused-function \
-Wno-bitwise-op-parentheses \
-Wno-shift-op-parentheses \
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ease adding new boards to projects, abstract out all the common bits into separate files.
Do the same for the toolchain bits.
I'm not sure whether the board descriptions should be here or in sDDF.