fix: Defer early Bash binds like macro chain (#2969) #2970
+87
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
akinomyoga
suggested changes
Oct 31, 2025
Contributor
There was a problem hiding this comment.
OK, when preparing #2953, I haven't assumed the case where bind will not be used at all.
One anticipated usage of --disable-up-arrow, --disbale-ctrl-r, or ATUIN_NOBIND is that the user disables the default keybindings and defines keybindings manually by themselves. In this usage, the user is expected to call atuin-bind, which uses the macro chaining anyway. This PR breaks this expected usage.
Could you modify the PR to perform the initialization on the first call of atuin-bind?
darkfeline
force-pushed
the
fix
branch
2 times, most recently
from
8c1e894 to
150f8b2
Compare
darkfeline
changed the title
Author
|
I believe I've addressed the |
darkfeline
changed the title
If the user is not binding any commands, then there is no need to do the various bind workarounds. This causes issues if the user deliberately disabled the bindings because their Bash session does not have the line editor enabled; attempts to call "bind" will then cause errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user is not binding any commands, then there is no need to do
the various bind workarounds. This causes issues if the user
deliberately disabled the bindings because their Bash session does not
have the line editor enabled; attempts to call "bind" will then cause
errors.
Checks