Fix: allow nonleading digits in NSID name segment #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few months ago, the spec was updated to the relax NSID syntax for the 'name' (last) NSID segment: non-leading digits are now permitted: bluesky-social/atproto-website#402 This change adds the new examples from the updated spec, which fail the current regex.
Fixes the failing tests with the [updated](bluesky-social/atproto-website#402) example NSIDs from the spec. This was a minimal change (just adding the `0-9`s), but i think the name-segment matcher could be further simplified: ``` (\.[a-zA-Z]([a-zA-Z0-9]{0,61}[a-zA-Z0-9])?) # current (\.[a-zA-Z][a-zA-Z0-9]{0,62}) # simpler, equivalent except for the internal capture group ``` but i will leave deciding that to maintainer taste.
sugyan
requested changes
May 25, 2025
Contributor
Author
|
sounds good! updated to the shorter regex and ran fmt -- i only added changes from |
sugyan
approved these changes
May 25, 2025
Merged
Member
|
Thank you for your contribution! https://github.com/atrium-rs/atrium/blob/main/atrium-api/CHANGELOG.md#0254---2025-05-25 |
Contributor
Author
|
amazing, thank you @sugyan !!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months ago, the spec was updated to the relax NSID syntax for the
name(last) segment of NSIDs: non-leading digits are now permitted: bluesky-social/atproto-website#402This change adds the new examples from the updated spec to the tests, and passes those test by adding
0-9to the middle and end[]groups of the NSID regex.This is a minimal change to pass the tests, but the
namesegment matcher could be further simplified:but that refactor is kind of to taste. happy to update the PR if you like it. as-is this PR has a bit more pattern consistency with the earlier segment matchers.