Skip to content

Extract common abstractions #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 21, 2024
Merged

Extract common abstractions #244

merged 18 commits into from
Nov 21, 2024

Conversation

@avdb13
Copy link
Contributor

@avdb13 avdb13 commented Nov 8, 2024

No description provided.

@avdb13 avdb13 changed the title Extract common abstraction utilities Extract common abstractions Nov 8, 2024
@avdb13 avdb13 marked this pull request as ready for review November 8, 2024 23:46
@sugyan sugyan self-requested a review November 9, 2024 14:12
sugyan
sugyan requested changes Nov 9, 2024
View reviewed changes
Copy link
Member

@sugyan sugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work!
I think this is a very nice implementation.
I have submitted a change request to your repository, including removing unnecessary dependencies. Please check that much.
avdb13#1

@avdb13 avdb13 requested a review from sugyan November 14, 2024 17:20
@sugyan
Copy link
Member

sugyan commented Nov 15, 2024

@avdb13 What about avdb13#1? I'd like to keep dependencies to a minimum and get rid of unnecessary code.

@avdb13
Copy link
Contributor Author

avdb13 commented Nov 15, 2024

@avdb13 What about avdb13#1? I'd like to keep dependencies to a minimum and get rid of unnecessary code.

Apologies, I did not know you opened a PR for my fork to suggest changes.

sugyan
sugyan approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@sugyan sugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sugyan sugyan merged commit de18c4f into atrium-rs:main Nov 21, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sugyan sugyan sugyan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avdb13 @sugyan