Skip to content

Conversation

@DanteNiewenhuis
Copy link
Contributor

@DanteNiewenhuis DanteNiewenhuis commented Nov 26, 2025

Summary

Fixed a small bug in the reading of workflows files that removed the children of some tasks.
This could result in an infinite loop.

Added a new test the experimentCLI that tests if a workflow can be run using the experimentCLI

Implementation Notes ⚒️

N / A

External Dependencies 🍀

N / A

Breaking API Changes ⚠️

N / A

Simply specify none (N/A) if not applicable.

@DanteNiewenhuis DanteNiewenhuis self-assigned this Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.55%. Comparing base (90d4369) to head (761233d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...g/opendc/compute/workload/ComputeWorkloadLoader.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #382      +/-   ##
============================================
+ Coverage     57.44%   57.55%   +0.10%     
  Complexity        1        1              
============================================
  Files           335      335              
  Lines         10826    10827       +1     
  Branches       1038     1039       +1     
============================================
+ Hits           6219     6231      +12     
+ Misses         4240     4229      -11     
  Partials        367      367              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DanteNiewenhuis DanteNiewenhuis merged commit 1de770c into atlarge-research:master Nov 26, 2025
5 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the workflow-fix branch November 26, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant