-
Notifications
You must be signed in to change notification settings - Fork 5
Bump dependencies #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #2110
Conversation
Signed-off-by: Chris (He/Him) <[email protected]>
Signed-off-by: Chris (He/Him) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Security dependency review job removed from PR workflow
The pr-security job that runs actions/dependency-review-action with fail-on-severity: moderate has been removed from the PR workflow. This job scanned pull requests for vulnerable dependencies and blocked merging if moderate or higher severity vulnerabilities were detected. Removing this security gate without replacement could allow dependencies with known vulnerabilities to enter the codebase undetected. This appears unrelated to the stated PR goal of "Bump dependencies."
.github/workflows/pr-build.yml#L57-L58
atlan-java/.github/workflows/pr-build.yml
Lines 57 to 58 in 607553a
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| NVD_API_KEY: ${{ secrets.NVD_API_KEY }} |
Signed-off-by: Chris (He/Him) <[email protected]>
Signed-off-by: Chris (He/Him) <[email protected]>
Signed-off-by: Chris (He/Him) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Removal of dependency security scanning workflow job
The pr-security job has been removed from the PR workflow. This job ran actions/dependency-review-action to scan for dependency vulnerabilities and fail on moderate or higher severity issues. Without this check, pull requests with vulnerable dependencies will no longer be blocked automatically, reducing the security posture of the CI pipeline. In a "Bump dependencies" PR, this removal seems unintentional or at least warrants explicit confirmation.
.github/workflows/pr-build.yml#L57-L58
atlan-java/.github/workflows/pr-build.yml
Lines 57 to 58 in c91079f
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| NVD_API_KEY: ${{ secrets.NVD_API_KEY }} |
Signed-off-by: Chris (He/Him) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Security dependency review job removed during dependency update
The pr-security job that runs actions/dependency-review-action with fail-on-severity: moderate has been completely removed from the PR workflow. This job was responsible for scanning pull requests for dependencies with known security vulnerabilities. Removing this security check in a PR that bumps dependencies is concerning, as it eliminates the automated safety net that would catch vulnerable dependencies before they're merged. This may have been unintentional or done to bypass a vulnerability check for one of the newly bumped dependencies.
.github/workflows/pr-build.yml#L48-L58
atlan-java/.github/workflows/pr-build.yml
Lines 48 to 58 in 664f103
| with: | |
| distribution: temurin | |
| java-version: 21 | |
| - name: Setup Gradle | |
| uses: gradle/gradle-build-action@ac2d340dc04d9e1113182899e983b5400c17cda1 # v3.5.0 | |
| - name: Unit tests | |
| run: ./gradlew test | |
| env: | |
| GH_USERNAME: ${{ github.actor }} | |
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| NVD_API_KEY: ${{ secrets.NVD_API_KEY }} |
Note
Updates key dependency versions and removes the PR dependency review job from the CI workflow.
org.pkl-lang:org.pkl-lang.gradle.pluginto0.30.1inbuildSrc/build.gradle.kts.gradle/libs.versions.toml:elasticsearch→9.2.2,awssdk→2.40.1,pkl→0.30.1,rhino→1.8.1.pr-securityjob (dependency review viaactions/dependency-review-action) from.github/workflows/pr-build.yml.Written by Cursor Bugbot for commit 664f103. This will update automatically on new commits. Configure here.