Fix hardcoded ID field name #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Needs more testing! :) |
Author
|
Ok, if you don't define the idField in the model the MasterCrud uses the "id" field as the index. Which is the way it should be. There was never a reason to hard-code it. If the idField is defined in the model though this is needed for getting the correct table index into the crud. |
mvorisek
reviewed
Dec 21, 2023
|
|
||
| if (isset($crud->table->columns[$this->model->title_field])) { | ||
| $crud->addDecorator($this->model->title_field, [Table\Column\Link::class, [], [$this->model->table . '_id' => 'id']]); | ||
| $crud->addDecorator($this->model->title_field, [Table\Column\Link::class, [], [$this->model->table . '_id' => $this->model->idField]]); |
Member
There was a problem hiding this comment.
$this->model->table . '_id' could be probably replaced with already build name from a reference object
mvorisek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix idField naming for those DBs where 'id' isn't used as the index-field.