-
-
Notifications
You must be signed in to change notification settings - Fork 996
Enhance layout and styling of sponsors section #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enhance layout and styling of sponsors section #4572
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
We require all PRs to follow Conventional Commits specification. |
WalkthroughThe PR updates sponsor components with styling improvements. PlatinumSponsors.tsx transitions from fixed-width responsive layout to a flexible grid system with gap utilities and replaces anchor styling with flex-based, interactive containers featuring hover effects. SponsorImage.tsx adds a hover scale animation and increases maximum image height. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4572 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 799 799
Branches 146 146
=========================================
Hits 799 799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4572--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
components/sponsors/PlatinumSponsors.tsx (1)
12-12: Fix the incorrect documentation.The comment states "This component displays Silver Sponsors" but the component is actually
PlatinumSponsorsand usesplatinumSponsorsdata.Apply this diff:
- * This component displays Silver Sponsors. + * This component displays Platinum Sponsors.
🧹 Nitpick comments (1)
components/sponsors/PlatinumSponsors.tsx (1)
26-26: Consider specifying transition properties for better performance.The
transition-allutility can be less performant than targeting specific properties. Since you're animating background and shadow on hover, consider being more specific.Apply this diff:
- className='group relative flex min-h-24 items-center justify-center rounded-lg p-4 transition-all duration-300 ease-in-out hover:bg-white hover:shadow-lg' + className='group relative flex min-h-24 items-center justify-center rounded-lg p-4 transition-[background-color,box-shadow] duration-300 ease-in-out hover:bg-white hover:shadow-lg'
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
components/sponsors/PlatinumSponsors.tsx(1 hunks)components/sponsors/SponsorImage.tsx(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
components/sponsors/PlatinumSponsors.tsx (1)
components/sponsors/PlatinumSponsorsList.ts (1)
platinumSponsors(3-18)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
🔇 Additional comments (3)
components/sponsors/SponsorImage.tsx (1)
16-23: LGTM! Hover animation and sizing improvements are well-implemented.The transition effects integrate nicely with the
groupclass added to the parent anchor in PlatinumSponsors.tsx. The increased max-height frommax-h-9 sm:max-h-12tomax-h-16provides better logo visibility.components/sponsors/PlatinumSponsors.tsx (2)
20-20: Good use of gap utilities for consistent spacing.The responsive gap utilities effectively address the whitespace issues mentioned in the PR objectives while maintaining a clean, flexible layout.
22-22: LGTM! Simplified list item styling.Removing fixed-width classes in favor of container-based sizing improves layout flexibility and maintainability.
This PR reworks the sponsor section to fix the whitespace issue by making a few key changes, including getting rid of the weird gaps and improving the logo sizing.
Please review and let me know if any changes are needed.
Fixes #4564
Summary by CodeRabbit