Skip to content

style: missing vertical spacing between navbar and announcement banner on tools, community, case studies, blog, and roadmap pages #4549 #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −4
Open

style: missing vertical spacing between navbar and announcement banner on tools, community, case studies, blog, and roadmap pages #4549 #4550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81a091e
[DESIGN]: Improve Styling of Goal Divs in Roadmap page #4543
erankitkr011 Nov 6, 2025
6077035
style: updated Goal div styling in Roadmap page (#4543)
erankitkr011 Nov 6, 2025
333cdc9
style: Missing vertical spacing between navbar and announcement banne…
erankitkr011 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/campaigns/AnnouncementHero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default function AnnouncementHero({ className = '', small = false }: IAnn
</div>
)}
<div className='relative flex w-4/5 md:w-5/6 flex-col items-center justify-center gap-2'>
<div className='relative flex min-h-72 w-full justify-center overflow-hidden lg:h-[17rem] lg:w-[38rem]'>
<div className='relative flex min-h-72 w-full justify-center overflow-hidden lg:h-[17rem] lg:w-[38rem] mt-4'>
{visibleBanners.map((banner, index) => {
// Only render the active banner
const isVisible = index === activeIndex;
Expand Down
6 changes: 3 additions & 3 deletions pages/roadmap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ export default function RoadmapPage() {

<div className='relative mt-20'>
<div className='grid lg:grid-cols-3 lg:gap-8'>
<div>
<div className='bg-white border border-gray-200 rounded-lg shadow-md p-6 flex flex-col justify-start lg:h-full'>
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Clarify the relationship between goal card styling and PR objective.

These changes add visual styling (white background, border, shadow, padding, flex layout) to the three goal cards, which improves their presentation. However, the PR objective states the purpose is to fix "missing vertical spacing between navbar and announcement banner."

It's unclear how styling these goal cards relates to the navbar/announcement spacing issue. Consider whether these changes should be in a separate PR for better change tracking and clarity.

If these changes are addressing a separate styling concern on the Roadmap page, please update the PR description to reflect the additional scope. Otherwise, consider moving these changes to a dedicated PR.

Also applies to: 552-552, 575-575

🤖 Prompt for AI Agents 
In pages/roadmap.tsx around lines 524, 552 and 575, the added card styling
(bg-white, border, shadow, p-6, flex, etc.) is unrelated to the stated PR
objective (fixing vertical spacing between navbar and announcement banner).
Either remove/revert these styling changes from this PR (restore the previous
classNames at those lines and move the styling edits into a new branch/PR), or
keep them but update the PR description to explicitly state the additional scope
(styling changes to the goal cards) and why they are included; implement one of
these two options and push the corresponding commit(s).

<div className='mb-2 lg:my-0 lg:text-center'>
<Paragraph
typeStyle={ParagraphTypeStyle.md}
Expand Down Expand Up @@ -549,7 +549,7 @@ export default function RoadmapPage() {
to integrate with the existing tools and specs instead.
</Paragraph>
</div>
<div>
<div className='bg-white border border-gray-200 rounded-lg shadow-md p-6 flex flex-col justify-start lg:h-full'>
<div className='mb-2 mt-6 lg:my-0 lg:text-center'>
<Paragraph
typeStyle={ParagraphTypeStyle.md}
Expand All @@ -572,7 +572,7 @@ export default function RoadmapPage() {
the programming language or framework of choice.
</Paragraph>
</div>
<div>
<div className='bg-white border border-gray-200 rounded-lg shadow-md p-6 flex flex-col justify-start lg:h-full'>
<div className='mb-2 mt-6 lg:my-0 lg:text-center'>
<Paragraph
typeStyle={ParagraphTypeStyle.md}
Expand Down
Loading