fix: override @hyperjump/json-schema to v1+ to fix Yarn build (fixes #2494)#2516
Open
armorbreak001 wants to merge 2 commits into
Open
fix: override @hyperjump/json-schema to v1+ to fix Yarn build (fixes #2494)#2516armorbreak001 wants to merge 2 commits into
armorbreak001 wants to merge 2 commits into
Conversation
✅ Deploy Preview for modelina canceled.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
…syncapi#2494) The transitive dependency @hyperjump/json-schema@0.23.x (required by alterschema) has a broken postinstall script that fails with ENOENT when the 'dist' directory does not exist. This blocks Yarn installs. @hyperjump/json-schema@^1.0.0 has fixed this postinstall issue. Adding npm overrides (and yarn resolutions as belt-and-suspenders) forces the fixed version throughout the dependency tree. Fixes asyncapi#2494
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2494
Problem
@asyncapi/modelinafails to build under Yarn due to a broken transitive dependency chain:The postinstall script in
@hyperjump/json-schema-core@0.28.xcallsrmSync('dist')on a directory that doesn't exist, crashing Yarn installs.Solution
Add
overrides(npm) andresolutions(yarn) to force@hyperjump/json-schema@^1.0.0throughout the dependency tree. Version 1.x has fixed the postinstall issue.Changes
overridesandresolutionsfields pinning@hyperjump/json-schemato^1.0.0Testing
yarn install+yarn build