Skip to content

Conversation

@juanmcloaiza
Copy link
Contributor

@juanmcloaiza juanmcloaiza commented Dec 9, 2025

Addresses #3473

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.49%. Comparing base (83c5c73) to head (e5f62ad).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3477   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files         234      234           
  Lines       20094    20094           
=======================================
  Hits        14366    14366           
  Misses       5728     5728           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clear addition to the instructions.

@bsipocz
Copy link
Member

bsipocz commented Dec 9, 2025

I see some docs build errors, I'll address them in review, rebase and then merge this.

Thank you @juanmcloaiza!

/Users/bsipocz/munka/devel/astroquery/docs/eso/eso.rst:107: WARNING: py:obj reference target not found: Eso.login() [ref.obj]
/Users/bsipocz/munka/devel/astroquery/docs/eso/eso.rst:107: WARNING: py:obj reference target not found: authenticated [ref.obj]
/Users/bsipocz/munka/devel/astroquery/docs/eso/eso.rst:123: WARNING: py:obj reference target not found: authenticated=False [ref.obj]

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding one more commit and rebase this, otherwise the note box look great. Thanks!

@bsipocz bsipocz merged commit e36a788 into astropy:main Dec 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants