MNT: Replace HTTP with HTTPS#125
Conversation
| packages will drop support for Python 2 no later than 2020. For instance, the | ||
| IPython developers have now released `IPython 5.0 | ||
| <http://blog.jupyter.org/2016/07/08/ipython-5-0-released/>`_, which will be the | ||
| <https://blog.jupyter.org/2016/07/08/ipython-5-0-released/>`_, which will be the |
There was a problem hiding this comment.
Hmm both HTTP and HTTPS links are dead. But fixing link is out of scope?
| project. This workflow is a massive improvement on the manual workflow currently | ||
| recommended to affiliated package authors in the | ||
| `Astropy documentation <http://docs.astropy.org/en/latest/development/affiliated-packages.html>`_. | ||
| `Astropy documentation <https://docs.astropy.org/en/latest/development/affiliated-packages.html>`_. |
There was a problem hiding this comment.
This URL is also dead because we reorganized the pages.
| commit on ``main`` as ``v4.1.dev``. In any case, the documentation about `how | ||
| to release the core package | ||
| <http://docs.astropy.org/en/stable/development/releasing.html>`_ will need to | ||
| <https://docs.astropy.org/en/stable/development/releasing.html>`_ will need to |
There was a problem hiding this comment.
Dev docs no longer available in "stable".
| .. _distutils: http://docs.python.org/2/library/distutils.html | ||
| .. _setuptools: http://pythonhosted.org/setuptools/ | ||
| .. _distutils: https://docs.python.org/2/library/distutils.html | ||
| .. _setuptools: https://pythonhosted.org/setuptools/ |
There was a problem hiding this comment.
| .. _setuptools: https://pythonhosted.org/setuptools/ | |
| .. _setuptools: https://setuptools.pypa.io/ |
There was a problem hiding this comment.
I am not sure about changing the actual URL, see #125 (comment)
| <https://vizier.u-strasbg.fr/doc/catstd.htx>`_ which is very widely used. The | ||
| Astrophysical Journal has adopted this standard for formatting `machine readable | ||
| tables <http://aas.org/authors/machine-readable-table-standards>`_ associated | ||
| tables <https://aas.org/authors/machine-readable-table-standards>`_ associated |
| this APE we have become aware of a very similar standard known as the | ||
| `Tabular Data Package | ||
| <http://dataprotocols.org/tabular-data-package/>`_. This provides a | ||
| <https://dataprotocols.org/tabular-data-package/>`_. This provides a |
| pure CSV for the data. The JSON header follows a schema defined by | ||
| the `JSON Table Schema | ||
| <http://dataprotocols.org/json-table-schema/>`_. | ||
| <https://dataprotocols.org/json-table-schema/>`_. |
|
@pllim - is this still in progress? The CoCo discussed this and agrees that this change does not trigger comment period or modification rules or anything so if you're done with it I think we are happy to just merge it |
|
I think I was done but not quite sure what to do with links we now know are dead. If you okay with deferring that, I think this is okay to merge but please do go through diff first just in case I missed something. |
kbwestfall
left a comment
kbwestfall
left a comment
There was a problem hiding this comment.
Hi @pllim :
I checked through all the links and found the following are broken. Maybe we should add a file that notes broken links we know of?
APE0:
YTEP 1776 <https://ytep.readthedocs.io/en/latest/YTEPs/YTEP-1776.html>
APE4:
setuptools: https://pythonhosted.org/setuptools/
APE6:
machine readable tables <https://aas.org/authors/machine-readable-table-standards>
Tabular Data Package <https://dataprotocols.org/tabular-data-package/>
JSON Table Schema <https://dataprotocols.org/json-table-schema/>
APE10:
IPython 5.0 <https://blog.jupyter.org/2016/07/08/ipython-5-0-released/>
six <https://pythonhosted.org/six/>
setuptools v24.2 <https://github.com/pypa/setuptools/blob/master/CHANGES.rst#v2420>
APE12:
Astropy documentation <https://docs.astropy.org/en/latest/development/affiliated-packages.html>
Cadair/pacakage-template <https://github.com/Cadair/package-template/tree/cookiecutter>
https://asciinema.org/a/7ilbwr10g0rj561clfkedui4j
APE17:
http://jinja.pocoo.org/docs/2.10/ automatically redirects to
https://jinja.palletsprojects.com/en/stable/ consider updating the link
Otherwise, all the http to https conversions look good to me.
I am afraid that such a file would introduce new maintenance cost if we don't go back and re-check it. Perhaps a follow-up issue? |
5 participants
HTTPS is recommended.