Support multiple Docker build secrets via newline-delimited input - #159
Draft
nickstenning wants to merge 1 commit into
Draft
Support multiple Docker build secrets via newline-delimited input#159nickstenning wants to merge 1 commit into
nickstenning wants to merge 1 commit into
Conversation
The build-secrets input was passed to `astro deploy --build-secrets` as a single argument, and the CLI in turn passed it to `docker build` as a single --secret flag, so there was no way to expose more than one secret to the image build: Docker parses the whole value as one secret spec in which later fields override earlier ones. Change the input to accept a newline-delimited list. Each line is passed to the CLI as its own `--build-secret` flag. As a side benefit, this input value is now threaded through the environment rather than interpolated into the script, so values containing shell metacharacters can no longer break (or inject into) the options-building step.
jlaneve
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build-secrets input was passed to
astro deploy --build-secretsas a single argument, and the CLI in turn passed it todocker buildas a single --secret flag, so there was no way to expose more than one secret to the image build: Docker parses the whole value as one secret spec in which later fields override earlier ones.Change the input to accept a newline-delimited list. Each line is passed to the CLI as its own
--build-secretflag.As a side benefit, this input value is now threaded through the environment rather than interpolated into the script, so values containing shell metacharacters can no longer break (or inject into) the options-building step.
Fixes #72.
Note: this cannot be merged until astronomer/astro-cli#2212 is merged and released.