Skip to content

Unpin Airflow to satisfy GitHub Security tab requirements #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Unpin Airflow to satisfy GitHub Security tab requirements #2171

wants to merge 3 commits into from

Conversation

@pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Nov 27, 2025

Unpin Airflow to satisfy GitHub Security tab requirements

@pankajastro pankajastro force-pushed the unpin_af_dependecy_in_docs branch from b624d06 to 860cbfa Compare November 27, 2025 08:20
pankajastro
pankajastro commented Nov 27, 2025
View reviewed changes
pankajastro
pankajastro commented Nov 27, 2025
View reviewed changes
docs/requirements.txt
Copy link
Contributor Author

@pankajastro pankajastro Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tatiana / @pankajkoti, do you know if you use this requirements.txt?

Copy link
Contributor

@pankajkoti pankajkoti Nov 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I believe the sphinx-notes/pages action used in the github/workflows/docs.yml uses it

Refer: https://github.com/sphinx-notes/pages?tab=readme-ov-file#inputs

@pankajastro pankajastro marked this pull request as ready for review November 27, 2025 08:24
Copilot AI review requested due to automatic review settings November 27, 2025 08:24
Copilot finished reviewing on behalf of pankajastro November 27, 2025 08:25
Copilot AI reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unpins the Apache Airflow version in the documentation requirements file to address GitHub Security tab requirements. The change removes the specific version pin (apache-airflow==2.10) in favor of allowing any version to be installed during documentation builds.

  • Removes the version constraint from apache-airflow==2.10 to apache-airflow in docs requirements
  • Aligns with previous security fix mentioned in CHANGELOG (not pinning Airflow 2.10.0)
  • Affects only documentation build dependencies, not runtime dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pankajastro
pankajastro commented Nov 27, 2025
View reviewed changes
@pankajastro pankajastro force-pushed the unpin_af_dependecy_in_docs branch from 94ba869 to 109d5a1 Compare November 27, 2025 09:04
pankajkoti
pankajkoti reviewed Nov 27, 2025
View reviewed changes
docs/requirements.txt
deprecation
msgpack
apache-airflow==2.10
apache-airflow>=2.6.0
Copy link
Contributor

@pankajkoti pankajkoti Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So previously, I guess this was deliberately pinned to 2.10 in 9adc29b via PR #2064

Were we able to confirm that if Airflow 3 gets installed the job will not fail anymore due to the structlog issue that surfaced earlier?

Copy link
Contributor Author

@pankajastro pankajastro Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll test it before merging.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.81%. Comparing base (9204a26) to head (109d5a1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2171   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          93       93           
  Lines        6009     6009           
=======================================
  Hits         5878     5878           
  Misses        131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pankajastro pankajastro marked this pull request as draft November 27, 2025 11:46
pankajkoti
pankajkoti approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once #2171 (comment) is tested out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pankajkoti pankajkoti pankajkoti approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pankajastro @pankajkoti