Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(sdk): runtime::capsule_set_epoch via astrid:sys@1.1.0 #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(sdk): runtime::capsule_set_epoch via astrid:sys@1.1.0 #61
Changes from all commits
ea2ddcbFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation states that
CapsuleSetEpochis opaque and its only meaning is equality. However, the inneru64field is currently public (pub u64), which allows external code to directly access, inspect, or manually construct arbitrary epoch values.To enforce encapsulation and preserve the opaque nature of the token, consider making the inner field private. Since
capsule_set_epoch()is defined in the sameruntimemodule, it will still be able to construct the struct, andserde's transparent serialization/deserialization will continue to work seamlessly.Uh oh!
There was an error while loading. Please reload this page.