Skip to content

docs(sdk): reference the [subscribe] handler form, not [[interceptor]] - #52

Closed
joshuajbouw wants to merge 1 commit into
mainfrom
docs/manifest-subscribe-handler
Closed

docs(sdk): reference the [subscribe] handler form, not [[interceptor]]#52
joshuajbouw wants to merge 1 commit into
mainfrom
docs/manifest-subscribe-handler

Conversation

@joshuajbouw

Copy link
Copy Markdown
Member

The [[interceptor]] manifest block is removed in astrid#863 (Closes astrid#858) — interceptors are now a [subscribe] entry with a handler. Updates the interceptors module doc comments (interceptors.rs, lib.rs) to describe the current form.

Doc-only — the SDK never parsed Capsule.toml, so no code change is needed for the manifest-schema migration.

…interceptor]] block

The [[interceptor]] manifest block is removed in astrid#863 (#858) — interceptors are now declared as a [subscribe] entry with a handler. Update the interceptors module docs to match. SDK code is unaffected (it never parsed the manifest); doc-only.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in astrid-sdk to reflect changes in how auto-subscribed interceptors are declared, replacing references to [[interceptor]] with a [subscribe] entry containing a handler. Additionally, it updates the contracts subproject commit. There are no review comments to address, and I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@joshuajbouw

Copy link
Copy Markdown
Member Author

Superseded by the clean redo (docs/interceptor-subscribe-handler). The doc fix is the same, but #52 also downgraded the contracts submodule to an old wit feat-branch commit (would regress the pin), so re-doing it doc-only on current main instead.

joshuajbouw added a commit that referenced this pull request Jun 16, 2026
#59)

Updates the `interceptors` module doc comments (interceptors.rs, lib.rs)
from the removed `[[interceptor]]` manifest block to the current
`[subscribe]` entry with a `handler` (astrid#863). Doc-only — the SDK
never parsed Capsule.toml.

Supersedes #52, which carried a regressive contracts-submodule downgrade
to an old wit feat-branch commit; this re-does just the doc fix cleanly
on current main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant