Skip to content

Simplify wheel entry-writer ownership - #1745

Draft
zaniebot wants to merge 1 commit into
mainfrom
zb/simplify-wheel-entry-writer
Draft

Simplify wheel entry-writer ownership#1745
zaniebot wants to merge 1 commit into
mainfrom
zb/simplify-wheel-entry-writer

Conversation

@zaniebot

Copy link
Copy Markdown
Collaborator

The private EntryWriter is always constructed with a live EntrySeekableWriter, and close consumes the wrapper. Store the inner writer directly instead of modeling an unreachable closed state with Option. write and flush delegate to the same live writer, while explicit close still completes the entry before its RECORD row is added.

@astral-automations-bot astral-automations-bot Bot added the internal A refactor or improvement that is not user-facing label Sep 13, 2026
@codspeed-hq

codspeed-hq Bot commented Sep 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 25 untouched benchmarks


Comparing zb/simplify-wheel-entry-writer (c6ce9d0) with main (c0df400)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant