Canonicalize resolved extra availability in lockfiles - #1743
Draft
zaniebot wants to merge 1 commit into
Draft
Conversation
zaniebot
force-pushed
the
zb/future-20260912-resolver-28
branch
from
September 13, 2026 01:57
45b3039 to
8ccb3a6
Compare
zaniebot
force-pushed
the
zb/future-20260912-resolver-28
branch
from
September 13, 2026 02:32
8ccb3a6 to
42515af
Compare
zaniebot
force-pushed
the
zb/future-20260912-resolver-28
branch
from
September 13, 2026 03:14
42515af to
4276c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A universal lock can retain a requested extra after all of that extra's resolved dependencies have been ruled out by markers. The serializer omits the empty section, so reading and refreshing the just-written lock removes the incoming extra reference. Drop empty extra sections after assembling the resolver output, then normalize incoming extra references before sorting and validating dependency edges. Existing locks may use an explicitly empty section to activate marked dependencies, so the reader retains those sections. Declaration-level
provides-extrasmetadata remains available, and extras with reachable dependencies in another marker domain remain in the lock.