Canonicalize effective lockfile dependency markers - #1735
Draft
zaniebot wants to merge 2 commits into
Draft
Conversation
astral-automations-bot
Bot
added
area:lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh
uv.lockcan failuv lock --check --refreshwhen reusing its forks drops an edge that was unreachable from its parent.MarkerTree::restrictonly fixes values within the assumed parent marker, so equivalent effective edges can otherwise be written differently. Intersect each edge with the parent's PEP 508 reachability before simplifying it. This gives those edges a stable representation without changing the resolved dependency coverage or discarding conflict predicates needed by older lockfile readers.