Skip to content

feat/passkey-pairing#343

Open
My-con wants to merge 3 commits into
asternic:mainfrom
My-con:feat/passkey-pairing
Open

feat/passkey-pairing#343
My-con wants to merge 3 commits into
asternic:mainfrom
My-con:feat/passkey-pairing

Conversation

@My-con

@My-con My-con commented Jul 3, 2026

Copy link
Copy Markdown

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for WhatsApp passkey pairing, adding several new endpoints (/session/passkey-response, /session/passkey-confirm, and /session/passkey-status), updating existing session status endpoints, and implementing a frontend UI modal and polling mechanism to handle the passkey flow. It also adds comprehensive unit tests and a background cleanup routine for stale passkey states. Feedback on the changes highlights a potential nil pointer dereference on state.Client in the passkey response handler, a missing implementation for auto-confirming passkeys when SkipHandoffUX is enabled, a memory leak of stale passkey states in stdio mode due to the cleanup routine not being started, and a minor frontend issue where the safety timeout is not cleared upon successful login.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread handlers.go
Comment thread wmiau.go
Comment thread main.go Outdated
Comment thread static/dashboard/js/app.js
@My-con

My-con commented Jul 3, 2026

Copy link
Copy Markdown
Author

Hi! Would you mind helping me finish this PR? I'd really appreciate it if you could take a look when you have some time. Thanks in advance!

image image image

My-con and others added 2 commits July 6, 2026 09:49
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@oAllanWeb

Copy link
Copy Markdown

@asternic ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants