Add supported languages to MCP tool parameter description #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebthom
changed the title
sebthom
force-pushed
the
patch-1
branch
2 times, most recently
from
6dce227 to
f8db328
Compare
|
@HerringtonDarkholme this PR is ready for review. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the MCP tool parameter descriptions by dynamically generating supported language lists based on ast-grep's built-in languages and any custom languages configured in sgconfig.yaml. This provides users with accurate, up-to-date information about which languages are supported when using the tools.
Key changes:
- Wrapped MCP tool definitions in a
register_mcp_tools()function to defer execution until after configuration is loaded - Added dynamic language support detection that includes both built-in and custom languages
- Updated test files to accommodate the new tool registration pattern
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| main.py | Added register_mcp_tools() function and get_supported_languages() helper, updated tool parameter descriptions to use dynamic language lists |
| tests/test_unit.py | Updated test setup to call register_mcp_tools() and extract tool functions from mocked MCP instance |
| tests/test_integration.py | Updated test setup to call register_mcp_tools() and extract tool functions from mocked MCP instance |
| pyproject.toml | Added PyYAML dependency for parsing sgconfig.yaml files |
| README.md | Added documentation links for language support and custom language configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@HerringtonDarkholme WDYT? |
HerringtonDarkholme
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the language parameter description is dynamically calculated on mcp server start based on the supported languages by ast-grep including custom languages configured in sgconfig.yaml
I had to wrap the mcp tool definitions into a function so that their language description field is not computed on import time but after the args are parsed and thus the sgconfig.yaml file can be loaded.
So to better review the PR check the changes with whitespace changes ignored: https://github.com/ast-grep/ast-grep-mcp/pull/11/files?w=1
An alternative to the current approach would be to move the mcp tool functions to a dedicated file (e.g. mcp_tools.py) and only do arg parsing, server setup in the main.py. this feels cleaner to me but is a bigger change. I would be happy to do that if you agree.