Skip to content

Conversation

sy-filis
Copy link
Contributor

@sy-filis sy-filis commented Jun 3, 2025

No description provided.

Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ngx-indexed-db ❌ Failed (Inspect) Jun 7, 2025 9:38am

@aparzi
Copy link
Collaborator

aparzi commented Jun 3, 2025

LGTM

@assuncaocharles for me the PR is ok. Is Vercel's mistake irrelevant?

@aparzi aparzi self-assigned this Jun 3, 2025
@aparzi aparzi added the Improvement Updating or evolving an existing feature label Jun 3, 2025
@aparzi
Copy link
Collaborator

aparzi commented Jun 7, 2025

Hi @sy-filis can you resolve conflicts? thanks

@aparzi aparzi merged commit cbb39d7 into assuncaocharles:master Jun 7, 2025
4 of 5 checks passed
@aparzi
Copy link
Collaborator

aparzi commented Jun 7, 2025

@sy-filis I merged this PR. let me know if using version 21.0.0 of the library is ok, because there might be some error in publishing

@aparzi
Copy link
Collaborator

aparzi commented Jun 7, 2025

yes yes clear I was referring to version 21.0.0 of the library if it works correctly in your project. because the released project has a different structure. that's all

@sy-filis
Copy link
Contributor Author

sy-filis commented Jun 7, 2025

@aparzi
It stopped working with Angular <=19 due to change of DOCUMENT import made by automatic migration.

With Angular 20 I am not able to test it because other libs does not support it yet. Sorry

SychovSergei pushed a commit to SychovSergei/ngx-indexed-db that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Updating or evolving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants