Added MVC jobs for cobalt cloud runs. #2097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces MVC scenario jobs to both the benchmarks matrix and the CI pipeline for Cobalt Cloud runs on Linux and AL3, along with minor formatting tweaks.
- Added new MVC jobs under the matrix definition for
cobalt-cloud-linandcobalt-cloud-lin-al3profiles. - Extended the CI YAML to include
Mvc_Cobalt_Cloud_LinuxandMvc_Cobalt_Cloud_Linux_AL3jobs with appropriate dependencies.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/benchmarks.matrix.azure.eastus2.yml | Added MVC job entries for both Linux and AL3 cobalt-cloud runs. |
| build/benchmarks-ci-azure-eastus2.yml | Inserted CI steps for MVC Cobalt Cloud Linux and Linux AL3 jobs. |
Comments suppressed due to low confidence (5)
build/benchmarks.matrix.azure.eastus2.yml:41
- [nitpick] Consider using the uppercase acronym 'MVC' instead of 'Mvc' for consistency with common naming conventions.
- name: Mvc Cobalt Cloud Linux
build/benchmarks.matrix.azure.eastus2.yml:77
- [nitpick] Use 'MVC' in the job name ('MVC Cobalt Cloud Linux AL3') to maintain acronym consistency.
- name: Mvc Cobalt Cloud Linux AL3
build/benchmarks-ci-azure-eastus2.yml:126
- There’s a trailing space after 'cobalt-cloud-lin' which could lead to an unintended profile name; remove the extra space.
arguments: "$(ciProfile) --profile cobalt-cloud-lin "
build/benchmarks-ci-azure-eastus2.yml:222
- An extra space at the end of the 'arguments' value may cause a mismatched profile; drop the trailing space.
arguments: "$(ciProfile) --profile cobalt-cloud-lin-al3 "
build/benchmarks-ci-azure-eastus2.yml:123
- [nitpick] Quote YAML values with spaces (e.g.
"ASPNET Benchmarks Service Bus") to avoid any parsing ambiguity.
connection: ASPNET Benchmarks Service Bus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Mvc jobs for cobalt cloud runs. Also fixed some minor formatting for the container jobs definition in the matrix. I tested this from the AL3 machine using the about-sqlite scenario successfully.