support quoted fields#65
Open
AlanBell wants to merge 1 commit intoaspiers:masterfrom
Open
Conversation
This supports quoted fields - but does require fields to be quoted in backticks - I think that is now a safe assumption. The objective is to support spaces in column names. The other line processing regexes might need to be updated as they can now encounter backticks but this seemed to be sufficient for my database dumps.
Author
|
relates to issue #43 |
|
@AlanBell , I've applied your changing to the file /usr/share/perl5/MySQL/Diff/Table.pm and It looks like does not work: Did you test your commit? |
Author
|
tested on my database, but didn't figure out the proper testing framework, never used perl before. I will have a look into it . . . |
|
@AlanBell , looks like you forgot to comment this line: Pierozi@ddeb987#diff-e6b990c7cda89648a6f3e28ba7146c3344cf0a4b98199bd0f759d0e1b1ed6ae7R326 |
quaternion7
added a commit
to quaternion7/mysqldiff
that referenced
this pull request
Jan 18, 2024
I merged the PRs aspiers#59 and aspiers#65 of the main branch while also cleaning them up a bit and double checking the code. It is still untested tho.
quaternion7
added a commit
to quaternion7/mysqldiff
that referenced
this pull request
Jan 18, 2024
My test failed like in the conversion on that PR. Going to try the fix mentioned there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports quoted fields - but does require fields to be quoted in backticks - I think that is now a safe assumption. The objective is to support spaces in column names.
The other line processing regexes might need to be updated as they can now encounter backticks but this seemed to be sufficient for my database dumps.