Conversation
|
98e540c to
4763211
Compare
4763211 to
e50ea58
Compare
b5eabf0 to
4e43f34
Compare
Member
|
Can a test be added showing what is being fixed? |
Member
Author
In theory yes, but not without setting up some additional platforms on RBE. |
Member
Author
|
Actually, we if we add an sdist dep to e2e then we'd test that the toolchain is registered properly on at least one platform. I'll update. |
f89c0ac to
0a11fdf
Compare
…form for sdist builds
0a11fdf to
5606a32
Compare
5606a32 to
dcc05d3
Compare
jbedard
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
native_build_toolchain(used bypep517_whlfor sdist builds) was not registered with@rules_py_tools//:alland it was a single static toolchain withuse_target_platform_constraints = True. This only matches when exec == target, but Bazel needs one registered entry per exec platform so it can resolvenative_build_toolchain_typefor each build host.Fix
Generate one
native_build_toolchainentry per exec platform intoolchains_repo(repo.bzl), so they land in@rules_py_tools//:allwhich is already registered by all users.native_build_toolchain_typenow resolves automatically on all supported exec platforms via the existingregister_toolchains("@rules_py_tools//:all").