Implement natural sort order for drive names #97
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive names were sorted lexicographically, causing pd10 and pd11 to appear before pd2-pd9.
Changes
string_natural_compare()insrc/hz/string_algo.h: Compares strings with numeric sequences treated as numbers rather than character-by-characterStorageDevicePtrcomparison operator insrc/applib/storage_device.h: Replaced string comparisons with natural sort for device base names, virtual filenames, and type argumentssrc/hz/tests/test_string_algo.cpp: 29 assertions covering device name sorting and edge casesExample
Before:
After:
Algorithm compares numeric sequences by magnitude:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.