fix: Add stacktrace to exception #265
Merged
+49
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception occured inside of a Reactor.Step it would not show the stacktrace but only the error message. This change includes the stacktrace in the exception and also adds a test that validates this.
This only works for "named" steps. The easiest way to also make it work for anonymous steps would be to remove the rescue clause from the
AnonFn.run/3
function:https://github.com/ash-project/reactor/blob/df74431bd1bc62a1c8935f86a65fc86abe13a9f4/lib/reactor/step/anon_fn.ex#L32C1-L33C29
Changing the
AnonFn.run/3
would be a breaking change so I wanted to discuss that first.Contributor checklist
Leave anything that you believe does not apply unchecked.