-
-
Notifications
You must be signed in to change notification settings - Fork 20
chore: REUSE compliance. #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b7523b1
to
ccf9fb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, REUSE.toml
is only really here for exceptions, I would add the licenses into most of those files directly.
"documentation/dsls/DSL-Reactor.md", | ||
"documentation/explanation/architecture.md", | ||
"documentation/explanation/concepts.md", | ||
"documentation/explanation/design-decisions.md", | ||
"documentation/explanation/ecosystem.md", | ||
"documentation/how-to/api-orchestration.md", | ||
"documentation/how-to/data-pipelines.md", | ||
"documentation/how-to/debugging-workflows.md", | ||
"documentation/how-to/payment-processing.md", | ||
"documentation/how-to/performance-optimization.md", | ||
"documentation/how-to/testing-strategies.md", | ||
"documentation/reference/glossary.md", | ||
"documentation/tutorials/01-getting-started.md", | ||
"documentation/tutorials/02-error-handling.md", | ||
"documentation/tutorials/03-async-workflows.md", | ||
"documentation/tutorials/04-composition.md", | ||
"documentation/tutorials/05-recursive-execution.md", | ||
"documentation/tutorials/reactor-cheatsheet.cheatmd", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend to use comments in the md files instead of a config. Example in elixir: https://github.com/elixir-lang/elixir/blame/main/README.md#L1-L5
"logos/reactor-logo-dark-medium.png", | ||
"logos/reactor-logo-dark-small.png", | ||
"logos/reactor-logo-dark.png", | ||
"logos/reactor-logo-dark.svg", | ||
"logos/reactor-logo-light-medium.png", | ||
"logos/reactor-logo-light-small.png", | ||
"logos/reactor-logo-light.png", | ||
"logos/reactor-logo-light.svg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use [PATH].license
files for things that you can't comment. See https://reuse.software/faq/#uncommentable-file
can we get a reference as to what REUSE is? edit: https://reuse.software/ |
Embrace the churn 😅
Contributor checklist
Leave anything that you believe does not apply unchecked.