Skip to content

Conversation

jimsynz
Copy link
Contributor

@jimsynz jimsynz commented Sep 21, 2025

Embrace the churn 😅

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@jimsynz jimsynz requested a review from zachdaniel September 21, 2025 01:27
@jimsynz jimsynz force-pushed the reuse branch 2 times, most recently from b7523b1 to ccf9fb1 Compare September 21, 2025 01:29
@jimsynz jimsynz requested review from a team and removed request for zachdaniel September 25, 2025 21:10
Copy link
Contributor

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, REUSE.toml is only really here for exceptions, I would add the licenses into most of those files directly.

Comment on lines +20 to +37
"documentation/dsls/DSL-Reactor.md",
"documentation/explanation/architecture.md",
"documentation/explanation/concepts.md",
"documentation/explanation/design-decisions.md",
"documentation/explanation/ecosystem.md",
"documentation/how-to/api-orchestration.md",
"documentation/how-to/data-pipelines.md",
"documentation/how-to/debugging-workflows.md",
"documentation/how-to/payment-processing.md",
"documentation/how-to/performance-optimization.md",
"documentation/how-to/testing-strategies.md",
"documentation/reference/glossary.md",
"documentation/tutorials/01-getting-started.md",
"documentation/tutorials/02-error-handling.md",
"documentation/tutorials/03-async-workflows.md",
"documentation/tutorials/04-composition.md",
"documentation/tutorials/05-recursive-execution.md",
"documentation/tutorials/reactor-cheatsheet.cheatmd",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend to use comments in the md files instead of a config. Example in elixir: https://github.com/elixir-lang/elixir/blame/main/README.md#L1-L5

Comment on lines +38 to +45
"logos/reactor-logo-dark-medium.png",
"logos/reactor-logo-dark-small.png",
"logos/reactor-logo-dark.png",
"logos/reactor-logo-dark.svg",
"logos/reactor-logo-light-medium.png",
"logos/reactor-logo-light-small.png",
"logos/reactor-logo-light.png",
"logos/reactor-logo-light.svg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use [PATH].license files for things that you can't comment. See https://reuse.software/faq/#uncommentable-file

@sevenseacat
Copy link
Contributor

sevenseacat commented Sep 26, 2025

can we get a reference as to what REUSE is?

edit: https://reuse.software/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants