Skip to content

fix: check for impl for all classes of errors. #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

fix: check for impl for all classes of errors. #365

merged 1 commit into from
Jul 21, 2025

Conversation

barnabasJ
Copy link
Contributor

@barnabasJ barnabasJ commented Jul 21, 2025 •
edited
Loading

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@barnabasJ barnabasJ self-assigned this Jul 21, 2025
@barnabasJ barnabasJ added the bug Something isn't working label Jul 21, 2025
@barnabasJ barnabasJ marked this pull request as ready for review July 21, 2025 10:18
@barnabasJ barnabasJ requested a review from zachdaniel July 21, 2025 10:19
@zachdaniel
Copy link
Contributor

Not following what problem this solves

@barnabasJ
Copy link
Contributor Author

Not following what problem this solves

Before, only the function that matched on class:: invalid actually looked for an implementation of the AshJsonApi.ToJsonApiError Protocol. Which led to other errors with a protocol implementation, to still return the generic error message and warning in the log.

@zachdaniel zachdaniel merged commit 86d995a into main Jul 21, 2025
22 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

Assignees

@barnabasJ barnabasJ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barnabasJ @zachdaniel