resolves #25 integrate Font Awesome 5 using SVG with JS; add icons to admonition blocks #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd icons to admonition blocks
36 tasks
|
We came up with a different approach for admonition and other built-in icons using Octicons with CSS. If we still wanted to support the use of custom icons in user content (meaning the icon macro), then this PR would need to be reworked to only target those elements. |
holly-cummins
added a commit
to holly-cummins/antora-ui-quarkiverse
that referenced
this pull request
Sep 27, 2023
holly-cummins
added a commit
to holly-cummins/antora-ui-quarkiverse
that referenced
this pull request
Sep 27, 2023
holly-cummins
added a commit
to holly-cummins/antora-ui-quarkiverse
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.