feat: reabilita bloqueio de merge para violacoes em codigo alterado #62
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR re-enables merge blocking for code violations after a monitoring period. The change removes the temporary bypass that was logging violations without blocking, and now actively blocks merges when P1 violations are detected in modified lines.
Key Changes:
- Re-enables the
exit 1command that enforces merge blocking for P1 violations in changed code - Updates user-facing messages to reflect the active blocking state
- Removes temporary monitoring notices
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🏷️ [bumpr] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
diogosgrott
approved these changes
Jan 9, 2026
joasgarcia
approved these changes
Jan 9, 2026
Contributor
|
🚀 [bumpr] Bumped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacto
Reabilitado o bloqueio de merge no codenarc-docker após período de monitoramento e validação.
Antes: Exit estava desabilitado temporariamente (# exit 1) apenas logando que "DEVERIA bloquear merge"
Agora: Exit reabilitado (exit 1) efetivamente bloqueando merge quando há P1s em linhas alteradas
Cenários testados
Funcionalidade já validada no PR anterior com 5 cenários de teste. Esta mudança apenas:
✅ Reabilita o exit 1 que estava comentado
✅ Mantém toda lógica de detecção inteligente inalterada
✅ Preserva comentários do reviewdog funcionando normalmente