feat: Add K/J keys for Focus{Prev,Next}SameKind#120
Closed
busfahrer wants to merge 1 commit intoarxanas:mainfrom
Closed
feat: Add K/J keys for Focus{Prev,Next}SameKind#120busfahrer wants to merge 1 commit intoarxanas:mainfrom
busfahrer wants to merge 1 commit intoarxanas:mainfrom
Conversation
Contributor
|
I just realized you implemented the exact same feature I had already implented in #113 haha (which says something about the demand for this!) |
Collaborator
|
Thanks for this PR! I think #113 is closer to being merged since it already updates the menu items. Let's move forward with that version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Disclaimer: I found out about this project because of jj-vcs)
I really like this tool for editing diffs, the only gripe I have with it that even though 90% of all commands are reachable using vim-style keys from the home row, one very common operation, namely jumping to the next/prev item at the same hierarchy level, forces me to leave home row.
This simple patch remedies this adding the analogous K and J key mappings for these operations.
edit: In case it's not clear, the keys are Shift+K and Shift+J