Skip to content

Breaking changes to see tests #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artpi wants to merge 1 commit into from
Closed

Breaking changes to see tests #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions personalos.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<?php //phpcs:disable WordPress.Files.FileName.InvalidClassFileName

// THIS SHOULD FAIL LINTING - wrong array syntax and spacing
$test_array = ['foo','bar'];

Check failure on line 4 in personalos.php

View workflow job for this annotation

GitHub Actions / lint-php 

Missing space before array closer.

Check failure on line 4 in personalos.php

View workflow job for this annotation

GitHub Actions / lint-php 

Expected 1 space between comma and "'bar'"; 0 found

Check failure on line 4 in personalos.php

View workflow job for this annotation

GitHub Actions / lint-php 

Short array syntax is not allowed

Check failure on line 4 in personalos.php

View workflow job for this annotation

GitHub Actions / lint-php 

Missing space after array opener.

/**
* Plugin Name: Personal OS
* Description: Manage your life.
Expand Down
2 changes: 2 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// THIS SHOULD FAIL LINTING - unused variable and double quotes
const unusedVariable = "test";

Check failure on line 2 in src/index.js

View workflow job for this annotation

GitHub Actions / lint-js 

Replace `"test"` with `'test'`

Check failure on line 2 in src/index.js

View workflow job for this annotation

GitHub Actions / lint-js 

'unusedVariable' is assigned a value but never used
import { registerPlugin } from '@wordpress/plugins';
import NotesPlugin from './notes/plugin';
import './notebooks/notebooks';
Expand Down
Loading